Fix max limit for load mean #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the upper limit in the Danfoss Ally spec? Maybe just use that? |
Nothing in the specs, just says it is calculated by the gateway |
|
The Danfoss spec defines the attribute as having a max value of 0x7FFF (range max column). It's probably better to use that instead of guessing soft limits. |
|
0x7FFF = 32767 decimal. That makes the HA slider unusable. That limit is basically a fictitious one by the manufacturer, but that high value will never be used. Hence 2000, since the highest i found in my testing and the data you 2 provided was in the region of 1.5k - 1.6k |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a further change to your initial min/max estimation
#3461
It turns out I was wrong about the max limit for load mean, where I have previously thought the limit is up to 100.
After some talking with users we have increased the limit. #3239 (comment)
Thanks @Koenkk
Hope you had a lovely Christmas and wishing you a Happy New Year!